-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Low modules filtering performance #1646
Comments
We also discovered this and keep on version 6.0.1 for now. We only have a few exclusions and inclusions but still its a significantly slower then before (x5 times) |
Hoping the maintainers of Coverlet are on vacation rather than the repository being inactive. So quietly here. |
@BlackGad thanks a lot for your contribution. I try to look into your PR on the weekend. |
@daveMueller Will this fix be shipped with version 6.0.3? |
Describe the bug
Recently, we encountered a performance issue with Coverlet during our CI pipeline processes.
Before executing
dotnet test
, we preprocess our CI build files to generate a runsettings file. This file specifies which assemblies to include and exclude based on pattern matching.The output directory ends up containing over 350 assemblies, including framework ones. Within this, the include section lists 54 patterns in the format
[Assembly1]*,[Assembly2]*
, while the exclude section contains 301 patterns, also specified in a similar manner.To Reproduce
Setup
runsettings
file and add Include and Exclude sections. Make sure that output folder contains a lot of modules.Solution that reproduces issue https://github.com/BlackGad/Coverlet.Issue
Expected behavior
Much faster processing
Actual behavior
Slow performance
Configuration (please complete the following information):
Please provide more information on your .NET configuration:
* Which coverlet package and version was used? - 6.0.2
* Which version of .NET is the code running on? - Net8.0
* What OS and version, and what distro if applicable? - Windows
* What is the architecture (x64, x86, ARM, ARM64)? - x64
* Do you know whether it is specific to that configuration? - Not related
Additional context
Link to solution with issue reproduce https://github.com/BlackGad/Coverlet.Issue
Link to PR that fixes issue #1645
The text was updated successfully, but these errors were encountered: