Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deterministic reports #1075

Closed
1 of 4 tasks
MarcoRossignoli opened this issue Jan 30, 2021 · 11 comments
Closed
1 of 4 tasks

Support deterministic reports #1075

MarcoRossignoli opened this issue Jan 30, 2021 · 11 comments
Labels
feature-request New feature request stale tenet-reporters Issue related to coverage output files(reporters)

Comments

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Jan 30, 2021

Follow up danielpalme/ReportGenerator#405

we could add a flag --deterministc-report and in case we're in a deterministic build use deterministic path instead of reconstruct the actual one.

cc: @clairernovotny @danielpalme

@MarcoRossignoli MarcoRossignoli added the feature-request New feature request label Jan 30, 2021
@MarcoRossignoli MarcoRossignoli pinned this issue Jan 30, 2021
@MarcoRossignoli MarcoRossignoli added the tenet-reporters Issue related to coverage output files(reporters) label Feb 8, 2021
@MarcoRossignoli MarcoRossignoli added the Priority:1 Very important to release, not a ship blocker label Feb 21, 2021
@MarcoRossignoli MarcoRossignoli unpinned this issue Mar 16, 2021
@MarcoRossignoli MarcoRossignoli removed the Priority:1 Very important to release, not a ship blocker label Nov 8, 2021
@pinkfloydx33
Copy link

Any idea if/when OpenCover will get support?

@MarcoRossignoli
Copy link
Collaborator Author

We don't have any plan for the moment, the interest looks not so high, if you want you can take it and I'll review it.

@pinkfloydx33
Copy link

pinkfloydx33 commented Feb 15, 2023

Ok thanks, I'll have to take a look... We don't really need it, we just have an unfortunate setup.

We need Cobertura reports for Azure Devops. We also need OpenCover for Sonar Cloud which doesn't support Cobertura format. We want to migrate our builds/reports to fully deterministic; we've been purposely overriding/disabling determinism in CI test runs due to now fixed issues with ADO+report-generator. Up until now we've been generating both formats, but of course that fails with the deterministic reports enabled since OpenCover doesn't support the flag.

I haven't found a tool that can turn Cobertura reports into OpenCover, but report-generator can supposedly output lcov format which I think Sonar can accept. That might be a viable option for us and likely less effort than trying to add support here.

@MarcoRossignoli
Copy link
Collaborator Author

I haven't found a tool that can turn Cobertura reports into OpenCover, but report-generator can supposedly output lcov format which I think Sonar can accept. That might be a viable option for us and likely less effort than trying to add support here.

@danielpalme can report generator convert Cobertura to OpenCover?

@danielpalme
Copy link

@danielpalme can report generator convert Cobertura to OpenCover?

No, OpenCover is not supported as output format (only Cobertura, lcov and Clover).

@petli
Copy link
Collaborator

petli commented Feb 17, 2023

@pinkfloydx33 ReportGenerator can convert to the generic SonarQube coverage format, maybe that will help you?

@pinkfloydx33
Copy link

Yeah I noticed that too. The generic format is somewhat limited I think. We already use it to report additional linting issues for our React apps so it's at least not foreign to us. I'd have to check if there's any implications in using that format over OpenCover wrt what Sonar displays/can report on for coverage purposes.

Generic format or lcov, I'm still going to have to update our CI processes to stop generating multiple formats directly, add a conversion step and then tweak the sonar parameters. Not a big deal, but would've preferred OC supported deterministic reports.

Is there any reason OC can't or that makes it difficult? Maybe I will look into offering a PR (ya know... If I ever get some time to myself 😄)

@danielpalme
Copy link

OpenCover is no longer maintained.

@dhduvall
Copy link

dhduvall commented Jun 2, 2023

FWIW, a discussion on Sonar's Discourse.

@github-actions
Copy link

This issue is stale because it has been open for 3 months with no activity.

@github-actions github-actions bot added the stale label Sep 24, 2023
Copy link

This issue was closed because it has been inactive for 9 months since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request stale tenet-reporters Issue related to coverage output files(reporters)
Projects
None yet
Development

No branches or pull requests

5 participants