From 0816bfba583243768108b28263e2c0b4b9dd3dc9 Mon Sep 17 00:00:00 2001 From: James Kessler Date: Tue, 1 Oct 2024 15:09:28 -0700 Subject: [PATCH 1/2] Add back the step that checks out the coverage-reporter source code, to get all coverage reports in various formats from coverage-reporter's test fixutres into our environment and make sure the binaries are tested against all supported coverage report formats. --- .github/workflows/build.yml | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9f9a532..e22f89f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,8 +104,16 @@ jobs: runs-on: ubuntu-latest needs: build-linux steps: - # - name: Checkout code - # uses: actions/checkout@v4 + # We don't technically need to download the coverage-reporter code here + # because in these tests we are downloading finished binaries and using them + # the same way customers do, but this is a convenient way to get all the + # coverage reports in various formats from coverage-reporter's test fixtures + # into our environment, making sure the binaries are tested against all + # supported coverage report formats. + # Removing this step will test each binary only against the latest coverage report + # for coverage-reporter itself, from the current CI run (in cobertura XML format). + - name: Checkout code + uses: actions/checkout@v4 - name: Download x86_64 binary uses: actions/download-artifact@v4 @@ -142,8 +150,16 @@ jobs: runs-on: ubuntu-latest needs: build-linux steps: - # - name: Checkout code - # uses: actions/checkout@v4 + # We don't technically need to download the coverage-reporter code here + # because in these tests we are downloading finished binaries and using them + # the same way customers do, but this is a convenient way to get all the + # coverage reports in various formats from coverage-reporter's test fixtures + # into our environment, making sure the binaries are tested against all + # supported coverage report formats. + # Removing this step will test each binary only against the latest coverage report + # for coverage-reporter itself, from the current CI run (in cobertura XML format). + - name: Checkout code + uses: actions/checkout@v4 - name: Download aarch64 binary uses: actions/download-artifact@v4 From d1d69626e3d254b92a2b3fd7da2b82c55f622d30 Mon Sep 17 00:00:00 2001 From: James Kessler Date: Tue, 1 Oct 2024 15:23:28 -0700 Subject: [PATCH 2/2] Trigger CI for a couple of clean RC builds with no history or change in coverage.