Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this orb support the coveralls or coveralls+ formats? #71

Closed
josegonzalez opened this issue May 12, 2023 · 6 comments
Closed

Does this orb support the coveralls or coveralls+ formats? #71

josegonzalez opened this issue May 12, 2023 · 6 comments
Labels
question Further information is requested

Comments

@josegonzalez
Copy link

Question

Does this orb support the coveralls or coveralls+ formats? From reading the readme/source, it seems like no, but I just want to be sure.

@josegonzalez josegonzalez added the question Further information is requested label May 12, 2023
@mrexox
Copy link
Contributor

mrexox commented May 15, 2023

No, currently it doesn't support coveralls/coveralls+ formats. But I am interested in adding the support for them. Can you share the tools you use to generate reports in these formats? It would be helpful.

@josegonzalez
Copy link
Author

I am using grcov for a rust-based program to generate those reports. I'm migrating from the old version of the coveralls orb that supports a node project for those formats, and wanted to see if maybe switching from lcov would fix my parsing issues.

@mrexox
Copy link
Contributor

mrexox commented May 29, 2023

I have added the support for coveralls format of grcov: #79. It will be available with the v0.4.3 release.

@mrexox mrexox closed this as completed May 29, 2023
@josegonzalez
Copy link
Author

josegonzalez commented May 30, 2023

Should it also support coveralls+ (I don't know what the difference is tbh)?

@mrexox
Copy link
Contributor

mrexox commented May 30, 2023

I've read the code for coveralls+ format - it adds functions field, but I'm afraid it doesn't get processed by Coveralls now. Maybe it was a few years ago (the code for coveralls+ format is written 6 years ago btw). So, basically coveralls+ adds nothing really special.

@josegonzalez
Copy link
Author

Thanks for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants