feat(permanentid): replace sha256 by md5(30)+sha1(30) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevost
requested review from
louis-bompart,
olamothe and
y-lakhdar
as code owners
jdevost
requested review from
olamothe and
francistb
and removed request for
olamothe
francistb
approved these changes
Jan 20, 2022
louis-bompart
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
LGMT! Same comment as coveo/push-api-client.java#17 (review)
y-lakhdar
approved these changes
Jan 20, 2022
louis-bompart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit for
permanentidin the index is actually 60 characters. hashlib.sha256() is generating a 64-character hash.Rather than simply truncating it, I am proposing the default algorithm to generate permanentid in the index:
md5[:30]+sha1[:30]