refactor(push)!: consolidate breaking changes and deprecations #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
changed the title
|
|
#113 is the breaking the API |
louis-bompart
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only an aggregation of the following 3 PRs.
Deprecation PRs
These PRs do not break the API even tho they introduce new methods by deprecating older ones. However, the older methods are still usable in these PRs.
Sourceclass toPushSource#110Breaking change PR
The Following PR breaks the interface by changing the return type of some methods
batchUpdateDocumentsFromFilesreturn type #113These breaking changes are the building blocks for the Stream API support which is covered in stream support branch.