Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form/Input propTypes "type" should include more types #78

Closed
CodeDraken opened this issue Sep 16, 2018 · 3 comments
Closed

Form/Input propTypes "type" should include more types #78

CodeDraken opened this issue Sep 16, 2018 · 3 comments

Comments

@CodeDraken
Copy link
Contributor

CodeDraken commented Sep 16, 2018

type: PropTypes.oneOf(['text', 'email', 'tel', 'password', 'number', 'search'])

Shouldn't this include color, file, and date as well?

https://github.com/couds/react-bulma-components/blob/master/src/components/form/components/input.js

@couds
Copy link
Owner

couds commented Sep 17, 2018

Hi @CodeDraken I think color and date could be, I'm planning to add the File input as another component because the behavior of its a little different (It is also another component on Bulma).

If you can fill a PR adding the other two types would be great.

Thanks

@CodeDraken
Copy link
Contributor Author

Yeah, I'll do a PR. Did you just want the types added or components for them?

@couds
Copy link
Owner

couds commented Sep 17, 2018

Can you add color and date to the type prop. File will be added as another component. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants