Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renderAs to receive another React-Bulma-Components Component as a value #315

Closed
couds opened this issue Apr 10, 2021 · 3 comments
Closed
Assignees
Labels
bug Typescript Issues on Typescript projects

Comments

@couds
Copy link
Owner

couds commented Apr 10, 2021

Currently the renderAs prop do not allow to compose using Components from the library itself

To Reproduce

In a TS project add

import React from 'react';
import { Content, Notification } from 'react-bulma-components';

function App() {
  return <Content renderAs={Notification} color="success">Any data</Content>;
}

See errors

image

image

Expected behavior

  • No errors
  • If possible autodetect the props as with html

Versions

  • react-bulma-components:: 4.0.0-RC.1
  • bulma: 0.9.2
  • react: 17
  • Browser: (e.g. Firefox version 67): NA
@couds couds added bug Typescript Issues on Typescript projects labels Apr 10, 2021
@kennethnym
Copy link
Collaborator

will fix asap.

@couds
Copy link
Owner Author

couds commented Apr 10, 2021

@kennethnym Thanks!

@kennethnym
Copy link
Collaborator

seems like this is fixed. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Typescript Issues on Typescript projects
Projects
None yet
Development

No branches or pull requests

2 participants