Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #242

Closed
kennethnym opened this issue Mar 21, 2020 · 21 comments · Fixed by #251
Closed

Documentation #242

kennethnym opened this issue Mar 21, 2020 · 21 comments · Fixed by #251

Comments

@kennethnym
Copy link
Collaborator

kennethnym commented Mar 21, 2020

Using a library that generates documentations from markdown files will make writing documentation much easier and less tedious. Updating documentation will also be easier too. Right now, we are using a full-blown create-react-app project just to display a static docs page. It is way too overkill and inefficient imo. cc @couds

@kennethnym
Copy link
Collaborator Author

It will also considerably speed up the process of creating the documentation.

@couds
Copy link
Owner

couds commented Mar 21, 2020

Hi. I understand what you mean but I believe in in using your own library to do the docs https://en.m.wikipedia.org/wiki/Eating_your_own_dog_food

@kennethnym
Copy link
Collaborator Author

docz, for example, lets you use your own components for the generated documentation. Is this what you prefer?

@couds
Copy link
Owner

couds commented Mar 23, 2020

@MrCreeper1008 Docs seem awesome, let's check its make sense to have docz and storybook. because both seem to be quite similar for showing the components.

@kennethnym
Copy link
Collaborator Author

kennethnym commented Mar 23, 2020

I'd say docz does a better job in documenting components because it actually is a documentation generator, whereas storybook is more geared towards component development. I think we don't need a storybook anymore if we adopt docz.

@kennethnym
Copy link
Collaborator Author

kennethnym commented Mar 30, 2020

I think docusaurus is a pretty good choice for creating our documentation because it supports custom components and i18n. I created a branch docs for all our work on the documentation. cc @couds

@kennethnym kennethnym changed the title Consider using a documentation generator like docsify Create documentation Mar 30, 2020
@kennethnym kennethnym pinned this issue Mar 30, 2020
@kennethnym kennethnym changed the title Create documentation Documentation Mar 30, 2020
@couds
Copy link
Owner

couds commented May 14, 2020

@MrCreeper1008 Thanks for keeping this on scope! as you suggest let's use docusaurus.I took a few days off from work to do this. I will take over this and try to have it done asap. I bought react-bulma.io I think It's better than the .dev (Use the same domain as bulma.io =) )

@kennethnym
Copy link
Collaborator Author

thanks! currently im still dealing with college stuff (it'll soon be over!) so i havent had time to work on the documentation. if you need help though please let me know. there are a lot to put into documentation so i'll help once i have the time.

@kennethnym
Copy link
Collaborator Author

kennethnym commented May 14, 2020

i've already setup docusaurus on docs branchk, so can start working on documentation directly.

@Quadrisheriff
Copy link
Contributor

Hi my name is Sheriff and will like to participate in this project too. Is there anyway we can like distribute the workload between all 3 of us?

@couds
Copy link
Owner

couds commented May 14, 2020

Hello, I just pushed a branch add-documentation that deploy here. I will continue tomorrow, and start with the docs for each component. After I finish the first component I will push it, after that we can assign components to each of us to create the documentation, the idea will be use the first component as a template for the rest.

@kennethnym
Copy link
Collaborator Author

Docusaurus 2 doesn't have i18n support. Are you planning to drop translation support?

@kennethnym kennethnym linked a pull request May 15, 2020 that will close this issue
33 tasks
@couds
Copy link
Owner

couds commented May 15, 2020

Yes, it does not make sense to use V1 if they are already working on V2.

@Quadrisheriff
Copy link
Contributor

We still waiting on the template PR 😀😀😀

@couds
Copy link
Owner

couds commented May 20, 2020

@Quadrisheriff Sorry currently I have my hand full. I don't think I will be able to upload the template. I uploaded the scafolding, if you want to start go ahead. the idea is to be a close as possible to the docs of bulma.io.

Also you can check the getting started in special the part about the Element component. I think that is the way we should go.

Thanks!

@Quadrisheriff
Copy link
Contributor

I have already started work on the elements, layout and components sections, and I should send a PR hopefully before this week's ending.

@kennethnym
Copy link
Collaborator Author

@Quadrisheriff thank you for your contribution. just a quick note: i have already documented column > basics and column > sizes, so can you please ignore these two parts when making the pr? makes it easier for me to merge. thanks!

@kennethnym
Copy link
Collaborator Author

@Quadrisheriff also please rebase your branch on top of the current documentation branch. thank you!

@timorthi
Copy link

Is #251 the most up-to-date branch for the new docs? Would love to contribute.

@kennethnym
Copy link
Collaborator Author

yes, i just merged #266 into add-documentation branch.

@kennethnym kennethnym unpinned this issue Dec 31, 2020
@couds
Copy link
Owner

couds commented Apr 22, 2021

Closing this, with V4 we will have a nicely documented library using storybook. Thanks to @kennethnym that did a great job 🎉

@couds couds closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants