CXXCBC-368: Subscribe to clustermap notifications to speedup failover #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
almost-faster-failover
branch
3 times, most recently
from
c2f2c03
to
353de38
Compare
avsej
force-pushed
the
almost-faster-failover
branch
from
353de38
to
b285e11
Compare
Implement only deduplication flag from the RFC, and enable clustermap change notifications. I this patch, we only want to use full notifications, and do not turn off polling. So the SDK will be able to receive new configuration sooner, but still be chatty as older versions.
avsej
force-pushed
the
almost-faster-failover
branch
from
b285e11
to
c2f7e58
Compare
It is possible that we will receive configuration, where nodes neither removed, nor added, but still we need to check the order of them in nodeExt, because at early stages of rebalance, ns_server might add new nodes to the end of the nodesExt list (while not adding them to serverList at all). In this case we don't want to keep this temporary order forever, and should be able to detect this condition an reorder them later.
thejcfactor
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement only deduplication flag from the RFC, and enable clustermap
change notifications. I this patch, we only want to use full
notifications, and do not turn off polling. So the SDK will be able to
receive new configuration sooner, but still be chatty as older versions.
Also this patch introduces tool cbc-beam that can send requests to specific vbucket or node id