CXXCBC-403: Allow retries for KV not_my_vbucket response #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
approved these changes
Nov 17, 2023
Motivation ---------- Currently if a KV operation receives a NMVB, it is possible the operation will raise a request_canceled error. When the client receives a NMVB there are circumstances in which we should attempt to retry the operation instead of raising a request_canceled. Changes ------- Update logic for handling NMVB KV responses so that retries are possible when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently if a KV operation receives a NMVB, it is possible the operation will raise a request_canceled error. When the client receives a NMVB there are circumstances in which we should attempt to retry the operation instead of raising a request_canceled.
Changes
Update logic for handling NMVB KV responses so that retries are possible when appropriate.