Be more specific about errors during invalid response for BLIP GetAttachment #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
approved these changes
Sep 12, 2023
adamcfraser
approved these changes
Sep 12, 2023
adamcfraser
deleted the
better_error_reporting_for_attachment_validation
branch
bbrks
added a commit
that referenced
this pull request
Sep 13, 2023
1 task
torcolvin
pushed a commit
that referenced
this pull request
Sep 13, 2023
bbrks
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more specific about what check failed when a peer sends invalid attachment data. Make
"length"explicitly required, instead of failing when it's going to end up as a failure to doToInt64(nil)Testing
Already covered via
TestPutInvalidAttachmentIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1999/