Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3352 switch Invalidate to Remove #6399

Merged
merged 1 commit into from
Sep 7, 2023
Merged

CBG-3352 switch Invalidate to Remove #6399

merged 1 commit into from
Sep 7, 2023

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Sep 7, 2023 •
edited
Loading

  • drop a lock by not checking the value before we remove it from the cache.
  • switched name from Invalidate to Remove for clarity

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

@torcolvin
CBG-3352 switch Invalidate to Remove
f4b6eed 
- drop a lock by not checking the value before we remove it from the
  cache.
- switched name from Invalidate to Remove for clarity
bbrks
bbrks approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@torcolvin torcolvin enabled auto-merge (squash) September 7, 2023 14:00
@torcolvin torcolvin merged commit 94071f8 into master Sep 7, 2023
26 checks passed
@torcolvin torcolvin deleted the CBG-3352-drop-double-lock branch September 7, 2023 14:49
torcolvin added a commit that referenced this pull request Sep 21, 2023
@torcolvin
CBG-3352 switch Invalidate to Remove (#6399)
4f297a9 
- drop a lock by not checking the value before we remove it from the
  cache.
- switched name from Invalidate to Remove for clarity
@torcolvin torcolvin mentioned this pull request Sep 21, 2023
Merged
4 tasks
torcolvin added a commit that referenced this pull request Sep 21, 2023
@torcolvin
CBG-3352 switch Invalidate to Remove (#6399)
e1b0020 
- drop a lock by not checking the value before we remove it from the
  cache.
- switched name from Invalidate to Remove for clarity
@torcolvin torcolvin mentioned this pull request Sep 21, 2023
Merged
4 tasks
torcolvin added a commit that referenced this pull request Sep 22, 2023
@torcolvin
[3.1.2 backport] CBG-3329: Fix rev cache multi node inconsistency (#6447
c9e0155 
)

backports:

* CBG-3171: Fix rev cache multi node inconsistency (#6369)
* CBG-3352 switch Invalidate to Remove (#6399)
torcolvin added a commit that referenced this pull request Sep 26, 2023
@torcolvin
[3.0.9 backport] CBG-3328 invalidate rev cache across nodes (#6448)
c4aa0af 
backports:

* CBG-3171: Fix rev cache multi node inconsistency (#6369)
* CBG-3352 switch Invalidate to Remove (#6399)
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@torcolvin @bbrks
CBG-3352 switch Invalidate to Remove (#6399)
9e8befd 
- drop a lock by not checking the value before we remove it from the
  cache.
- switched name from Invalidate to Remove for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @bbrks