CBG-3289 handle in memory walrus databases as rosmar databases #6379
+94
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
previously requested changes
Aug 24, 2023
rest/config.go
Outdated
Comment on lines
92
to
93
| // walrus:data represents in memory data store, convert this to rosmar.InMemoryURL | ||
| // but do not match walrus:///path/to/db, which is incompatible with rosmar URLs |
There was a problem hiding this comment.
I left a more detailed comment in Slack about this, but walrus:data is a persisted Walrus bucket, with a relative path to data (and only if that directory exists... and then it's not persisted 🙃)
adamcfraser
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle in memory walrus databases as rosmar databases. Tests to make sure that old-style in memory databases (
walrus:data), rosmar in memory (rosmar:/?mode=memory), and rosmar on disk all will work without being part of a bucket pool.Removed a context.TODO()/context.Background() because there was always a clear calling context.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/api