Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/506 #519

Closed
wants to merge 2 commits into from
Closed

Issue/506 #519

wants to merge 2 commits into from

Conversation

z000z
Copy link

@z000z z000z commented Oct 20, 2015

Fixes for Issue 506

…Info.GetValue / .SetValue. Moving to GetGetMethod.Invoke and GetSetMethod.Invoke
…pdated UnityMainThreadScheduler to work with the changes made to the SingleThreadScheduler
@borrrden
Copy link
Member

Thanks for submitting this. I'm going to have to analyze it and apply it to the Unity release branch instead of master (Unity release and master are pretty far apart). I'll do it sometime next week I think (after I finish up the current ForestDB stuff I am working on).

@borrrden
Copy link
Member

Also, I may have asked before, but have you signed the (electronic) contributor agreement?

@z000z
Copy link
Author

z000z commented Oct 20, 2015

Sounds good, yup all signed.

@zgramana zgramana added this to the 1.2 milestone Oct 30, 2015
@borrrden
Copy link
Member

I don't know if you noticed but we finally have a fix for Issue #481 coming. Once it lands I'll definitely be making a large Unity sprint including this PR, and I might get to it before but I haven't forgotten about it!

@z000z
Copy link
Author

z000z commented Oct 31, 2015

Ah that's good to hear I've been trying to watch the Unity patches to see if they had addressed that issue yet or not.

@borrrden
Copy link
Member

I have to merge this into the unity-ga branch instead of master. Eventually merging into master will be correct but unity-ga has gotten out of sync while waiting on Issue #481. However most of the PR does not apply to unity-ga, so I simply made a commit with the relevant info from this PR and referenced this page. The commit is in issue/523 since the two seem to be related (another customer is experiencing the same error message with HTTPS requests).

@borrrden borrrden closed this Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants