Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom encryption Salt and Rounds in version 2.x #1031

Open
alexrainman opened this issue Jun 2, 2018 · 5 comments
Open

Provide custom encryption Salt and Rounds in version 2.x #1031

alexrainman opened this issue Jun 2, 2018 · 5 comments

Comments

@alexrainman
Copy link

Before version 2 i was doing this:

opts.EncryptionKey = new SymmetricKey("KeySeed", "SaltText", rounds);

Now a custom Salt and Rounds cannot be provided:

var config = new DatabaseConfiguration
{
    EncryptionKey = new EncryptionKey("KeySeed") // using default salt and rounds
};

Will that functionality be provided again?

@alexrainman alexrainman changed the title Provide custom encryption Salt and Rounds Provide custom encryption Salt and Rounds in version 2.x Jun 2, 2018
@borrrden
Copy link
Member

borrrden commented Jun 4, 2018

I assume you want to say "please provide this functionality again" instead of asking a question, since the place for questions is the forums ;). The end result of the debate around this was to wait and see how many people asked for it, so I will keep this ticket around. If you find more people that want it (on other platforms also) then have them follow up as well.

@djpongh djpongh added this to the 2.2.0 milestone Jun 15, 2018
@djpongh djpongh added the icebox label Jun 15, 2018
@djpongh djpongh modified the milestones: Iridium, Cobalt Dec 6, 2018
@djpongh djpongh added icebox and removed backlog labels Dec 6, 2018
@borrrden
Copy link
Member

borrrden commented Jun 1, 2019

@djpongh Need an answer on doing this or not. I assume Cobalt is out at this point.

@alexrainman
Copy link
Author

Good to know you guys are considering this. I also hope encryption becomes again a free feature. Thanks

@borrrden borrrden removed this from the Cobalt milestone Jun 4, 2019
@borrrden
Copy link
Member

borrrden commented Jun 4, 2019

Just a little side note here: If you want to derive your own key that's also certainly possible, just use the byte[] constructor instead. The actual way to get to this point is pretty easy, and you can use this as a reference

@borrrden
Copy link
Member

Tracking in CBL-401 (but status still remains undiscussed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants