Fixes #756 (#791)

* Make sure that every place a document could be rejected by the endpoint is logged and stored in LastError
* Add in a new test for 403 errors

src/Couchbase.Lite.Shared/Replication/Pusher.cs

@@ -281,10 +281,12 @@ private void UploadBulkDocs(IList<object> docsToSend, RevisionList revChanges)
                             // 403/Forbidden means validation failed; don't treat it as an error
                             // because I did my job in sending the revision. Other statuses are
                             // actual replication errors.
-                            if (status.Code != StatusCode.Forbidden)
-                            {
+                            if(status.Code != StatusCode.Forbidden) {
                                 var docId = itemObject.GetCast<string>("id");
                                 failedIds.Add(docId);
+                            } else {
+                                LastError = Misc.CreateExceptionAndLog(Log.To.Sync, StatusCode.Forbidden, TAG,
+                                    $"{itemObject["id"]} was rejected by the endpoint with message: {itemObject["reason"]}");
                             }
                         }
                     }
@@ -390,9 +392,12 @@ private bool UploadMultipartRevision(RevisionInternal revision)
                 if (e != null) {
                     var httpError = Misc.Flatten(e).FirstOrDefault(ex => ex is HttpResponseException) as HttpResponseException;
                     if (httpError != null) {
-                        if (httpError.StatusCode == System.Net.HttpStatusCode.UnsupportedMediaType) {
+                        if(httpError.StatusCode == System.Net.HttpStatusCode.UnsupportedMediaType) {
                             _dontSendMultipart = true;
                             UploadJsonRevision(revision);
+                        } else if(httpError.StatusCode == System.Net.HttpStatusCode.Forbidden) {
+                            LastError = Misc.CreateExceptionAndLog(Log.To.Sync, StatusCode.Forbidden, TAG,
+                                                                       $"{revision.DocID} was rejected by the endpoint with message");
                         }
                     } else {
                         LastError = e;
@@ -427,8 +432,14 @@ private void UploadJsonRevision(RevisionInternal originalRev)
             {
                 if (e != null) 
                 {
-                    LastError = e;
-                    RevisionFailed();
+                    var httpError = Misc.Flatten(e).FirstOrDefault(ex => ex is HttpResponseException) as HttpResponseException;
+                    if(httpError != null) {
+                        LastError = Misc.CreateExceptionAndLog(Log.To.Sync, StatusCode.Forbidden, TAG,
+                                                                       $"{rev.DocID} was rejected by the endpoint");
+                    } else {
+                        LastError = e;
+                        RevisionFailed();
+                    }
                 } 
                 else 
                 {

src/Couchbase.Lite.Tests.Shared/Assets/GatewayConfig.json

@@ -11,7 +11,13 @@
                 "jim" : { "password": "borden", "admin_channels": ["*"]}
               },
              "bucket":"testing",
-             "sync":`function(doc) {channel(doc.channels);}`
+             "sync":`function(doc) {
+               if(doc.reject) {
+                throw({forbidden: "Reject was set to true!"})
+               }
+
+               channel(doc.channels);
+             }`
           },
           "openid_db": {
             "server":"walrus:",

src/Couchbase.Lite.Tests.Shared/ReplicationTest.cs

@@ -64,6 +64,7 @@
 using System.Net.Sockets;
 using Couchbase.Lite.Revisions;
 using System.Diagnostics;
+using FluentAssertions;
 
 #if NET_3_5
 using WebRequest = System.Net.Couchbase.WebRequest;
@@ -227,6 +228,53 @@ protected override void SetUp()
             base.TearDown();
         }*/
 
+        [Test]
+        public void TestRejectedDocument()
+        {
+            var push = database.CreatePushReplication(GetReplicationURL());
+            var wait = new WaitAssert();
+            push.Changed += (sender, e) => {
+                var err = e.LastError as HttpResponseException;
+                if(err != null) {
+                    wait.RunAssert(() => err.StatusCode.Should().Be(HttpStatusCode.Forbidden,
+                                                                    "because the document should be rejected"));
+                }
+
+                var err2 = e.LastError as CouchbaseLiteException;
+                if(err2 != null) {
+                    wait.RunAssert(() => err2.Code.Should().Be(StatusCode.Forbidden,
+                                                                    "because the document should be rejected"));
+                }
+            };
+
+            database.CreateDocument().PutProperties(new Dictionary<string, object> {
+                ["reject"] = false
+            });
+
+            database.CreateDocument().PutProperties(new Dictionary<string, object> {
+                ["reject"] = true
+            });
+
+            push.Start();
+
+            wait.WaitForResult(TimeSpan.FromSeconds(5));
+
+            var docWithAttach = database.CreateDocument();
+            docWithAttach.Update(rev => {
+                rev.SetUserProperties(new Dictionary<string, object> {
+                    ["reject"] = true
+                });
+
+                rev.SetAttachment("foo", "foo/bar", Enumerable.Repeat<byte>((byte)'a', 100000));
+                return true;
+            });
+
+            wait = new WaitAssert();
+            push.Start();
+
+            wait.WaitForResult(TimeSpan.FromSeconds(5));
+        }
+
         [Test]
         public void TestUnauthorized()
         {