-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OS X build product #655
Comments
Should just be an addition to the Jenkins build script. It needs to build the |
@ashvindersingh, could you also add test the OSX build in your XCODE server as well? |
Per talking with @ashvindersingh, Ashvender will talk to the build team to setup the jenkin build for OSX. |
So we are looking to add mac-osx build on top of the existing iOS for couchbase-lite-ios. I like to confirm a few things.
|
Same Xcode project. See my comment above on what targets to build. |
I will add those 2 targets for MAC. I also need to update the build script to separate the mac vs ios builds. |
@michaelkwok, thanks a lot for your help. |
Here are a few changes right off the bat.
|
In #4, I am referring to internal builds. Release builds still go to S3. |
Are you creating a new package? If so, yeah, that's a good name. |
I have added the Mac Unit tests to Xcode server. The tests will run once daily. |
@snej, I have created the new macosx as a separate package. The macosx build generates this library Release-CBLJSViewCompiler-ios-universal/libCBLJSViewCompiler.a, same as the ios build. Does macosx need to include this library? The reason I ask is because the name ios package includes this library. But the name Release-CBLJSViewCompiler-ios-universal almost suggest it's not for macosx. |
Nope, just ignore that library in the Mac build. |
The job build_cblite_ios_master is now building both ios and macosx. All results are now kept in our internal latestbuilds. |
👍 For the record, Pasin and I found some issues with the content of the archive and Michael is fixing them now. |
Jens/Pasin, can you make sure I didn't strip too much from macosx and also verify ios builds are the same as before? Nothing changed on ios but I just want to make sure I didn't overlook something. http://latestbuilds.hq.couchbase.com/couchbase-lite-ios/macosx/0.0.0/0.0.0-378/ |
I checked the OSX framework structure with Jens and it seems to be correct now. A couple things apart that:
|
I have removed JavaScriptCore.framework from ios "Extras". Thanks! |
I think this task is done. Close the issue now. Thanks a lot @michaelkwok . |
No description provided.
The text was updated successfully, but these errors were encountered: