Removing extra padding in nested lists

[joshjohanning]

Closes #702

Description

Removing extra padding in nested lists

From:

To:

This reflects more of how it looks like in GitHub:

• Coffee
• Tea
  • Black tea
  • Green tea
• Milk

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

(Depending on how you look at this, could be bug, could be feature 🤷 )

How has this been tested

• I have run bash ./tools/test.sh (at the root of the project) locally and passed
• I have tested this feature in the browser

Tested with latest master branch

Test Configuration

• Browser type & version: Chrome latest
• Operating system: macOS latest
• Ruby version: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
• Bundler version: Bundler version 2.3.7
• Jekyll version: jekyll (4.2.2)

Checklist

• I have performed a self-review of my code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[cotes2020]

Thanks for pointing this out! The space between lists does need to be optimized, I'll modify your commit and merge it later.

[joshjohanning]

Thank you @cotes2020 😄

[joshjohanning]

@cotes2020 I still feel like the padding is way too much. For small lists, I think it is probably fine, but for large lists, it takes up way too much room. This is how it looks now after this PR:

It's maybe personal preference, but I don't see why we wouldn't want to tighten this in a little bit? It seems like there is plenty of spacing between list items with using 0.0 margin.

Also, why different value for li than ul?

What do you think? 😄

[cotes2020]

... I don't see why we wouldn't want to tighten this in a little bit? It seems like there is plenty of spacing between list items with using 0.0 margin.

The space between list items(<li>) should be slightly larger than the line spacing within the paragraph(<p>). If the margin-{top|bottom} is set to 0, then the list items will not stand out.

Also, why different value for li than ul?

ul is the outer edge of a list, and li is the element of the list, so the line spacing of the two is also different.

[joshjohanning]

With the margins set to 0, I think that the list items stand out perfectly well 😄

[cotes2020]

Hi @joshjohanning, I reduced the space between list items by 4px, but it's still a bit larger than the line spacing of paragraphs: because that's a typographic convention.

Also, I fixed the left indent of the list block 😂

[joshjohanning]

@cotes2020 🎉 I think that looks a lot better! Thank you.