Custom javascript files are not copied to the output folder

[kungfux]

Checklist

• I have read and accepted the contributing guidelines.

How did you create the site?

Generated from chirpy-starter

Describe the bug

Custom javascript files are not copied to the output folder after upgrading to 7.2.1, because changes made in #2090 are promoted to the Chirpy starter template.

Steps To Reproduce

1. Have custom scripts in assets folder
2. Build website

Expected Behavior

Custom scripts are copied to the output folder.

Environment

• Ruby: ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux]
• Jekyll: jekyll 4.3.3
• Chirpy: 7.2.1

Anything else?

Workaround: edit _config.yml as follows

exclude:
- - "*.js"
+ - purgecss.js

[cotes2020]

Steps To Reproduce

Have custom scripts in assets folder

Can you be more specific?

[kungfux]

Can you be more specific?

I have custom javascript files in assets/js folder that are being included from markdown or metadata-hook.html files.

root/
├── _includes/
│   └── metadata-hook.html
└── assets/
    └── js/
        └── my-script.js

<script src="/assets/js/my-script.js" defer></script>

This worked as javascript files are copied to _site/assets/js folder on build. Since javascript files are excluded in the config now, they are no being copied.

If I remove the following parameter in _config.yml, then my javascript files will be copied.

exclude:
  - "*.js"

Is this something we would like to avoid by default?

[cotes2020]

The pattern *.js will only exclude js files in the root directory and does not apply to js files in the assets folder. So I'm curious how you came to this conclusion? Did it exclude the js files in the assets/ folder after running it?

BTW, I tested this pattern locally before commit #2090, and it will copy the JS files in the subdirectories to the output directory.

[kungfux]

I see what you're saying.

• Matches any file. Can be restricted by other values in the glob. Equivalent to /.*/x in regexp.

Here's what I'm observing though. When I add *.js to the exclude section, there are no js files in the _site/assets/js folder after the build. When I remove it, the js files are there.

OK, I will try to find the cause on my end. At the moment I have no idea why it works differently for you.

[cotes2020]

Sorry, I made a mistake. When checking the output with ls command, the path I entered was missing the _site/ prefix.

Using ruby to check, it's confirmed that *.js can match files in subdirectories.

# test.rb
puts File.fnmatch('*.js', 'sub/script.js')        # output: true
puts File.fnmatch('*.js', 'assets/js/script.js')  # output: true

It seems that ruby has a different pattern than the shell and needs to be used more carefully.

[kungfux]

Thanks for checking @cotes2020

[github-actions]

🎉 This issue has been resolved in version 7.2.2 🎉

The release is available on:

• v7.2.2
• GitHub release

Your semantic-release bot 📦🚀