Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consider breaking out gas-prices config value into two different values #1414

Open
jtieri opened this issue Mar 1, 2024 · 0 comments
Labels
C: Relayer COMPONENT: Relayer R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor

Comments

@jtieri
Copy link
Member

jtieri commented Mar 1, 2024

Currently the relayer has a config value, gas-prices, that is a string representing both the gas price as well as the token denom. I propose that we break this value into two config fields, gas-price and gas-token-denom.

In its current state if you want to work with just the gas price or just the token denom you have to do some parsing of this string that involves regex and imo introduces an unnecessary area where bugs may occur. Breaking the existing config field into two fields will make working with chains that support dynamic fee markets easier.

This would be a breaking change to existing configs though so would need to be included in a major release.

@jtieri jtieri added R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor C: Relayer COMPONENT: Relayer labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Relayer COMPONENT: Relayer R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor
Projects
None yet
Development

No branches or pull requests

1 participant