Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ana/enable more networks actions #3443

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Conversation

Bitcoinera
Copy link
Contributor

Closes #ISSUE

Description:

Here I just updated the MessageConstructor.js and ledger.js files to support actions for all these new networks we are adding (and which now have actions enabled in networks.json)

Still, there are a couple of things with Ledger that don't work yet. Signing with Ledger in Regen when sending tokens throws the following error:

But I presume this is material for another PR.

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3443 into develop will decrease coverage by 0.51%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##           develop    #3443      +/-   ##
===========================================
- Coverage    87.16%   86.65%   -0.52%     
===========================================
  Files          124      124              
  Lines         2493     2510      +17     
  Branches       333      358      +25     
===========================================
+ Hits          2173     2175       +2     
- Misses         313      326      +13     
- Partials         7        9       +2
Impacted Files Coverage Δ
src/ActionModal/utils/MessageConstructor.js 74.57% <0%> (-25.43%) ⬇️
src/scripts/ledger.js 93.54% <100%> (+0.44%) ⬆️

@faboweb
Copy link
Collaborator

faboweb commented Jan 20, 2020

Regen also needs the message files in ActionModal/utils/networkMessages

@Bitcoinera
Copy link
Contributor Author

Let merge this and bring cross networks done closer! 💪

@faboweb faboweb merged commit 8bd3d57 into develop Jan 21, 2020
@faboweb faboweb deleted the ana/enable-other-networks-actions branch January 21, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants