-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send button is still enabled even when extension is not installed #3330
Comments
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hi @jbibla, I can't reproduce this on Windows/Chrome/Brave. At least in my test, Send button is disabled with the message "Waiting for extension". |
hmm. on mac with brave i can reproduce. also, there should be some instructions, no? |
I tested with extension disabled and uninstalled, I didn't see any instructions. |
Adding: I don't like this step and still propose that we make this step: "To continue please sign in to your address" |
yeah this is a related bug. should be resolved. |
i'm working on it now. |
Describe the bug
if you select "extension" in an action modal as signing method, the message will ask the user to install the extension. however, the button is still enabled which means it can be "sent" even though this will never work.
Expected behavior
button should be disabled OR should be an "install" / "go to chrome store" button
The text was updated successfully, but these errors were encountered: