Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling blocks of networks which haven't yet the feature activity implemented #3282

Closed
Bitcoinera opened this issue Dec 10, 2019 · 4 comments · Fixed by #3411
Closed

Handling blocks of networks which haven't yet the feature activity implemented #3282

Bitcoinera opened this issue Dec 10, 2019 · 4 comments · Fixed by #3411

Comments

@Bitcoinera
Copy link
Contributor

Describe the bug

You can see the blocks of networks which don't have yet the activity feature enabled. They look like empty, with no Chain ID.

To Reproduce

Connect to Livepeer ( which hasn't activity yet implemented) and click on the block on the bottom (TmConnectedNetwork). You will see this 'fake' empty block.

Expected behavior

I think the ideal would be to have here the same modal of Feature not yet available.

Screenshots

The fake empty block:

image

Desktop (please complete the following information):

  • OS:
  • Browser:
  • Version:

Smartphone (please complete the following information):

  • Device:
  • OS:
  • Browser
  • Version

Additional context

@jbibla
Copy link
Collaborator

jbibla commented Dec 10, 2019

good catch.

my idea would be to use a feature flag for it. if "block" is disabled, anywhere we show the block number should appear as plain text, not a link.

if enabled, they should be links.

but this is just one idea - there may be better ways to deal with this!

maybe the simplest thing to do is to show the "feature not available" screen for now.

@stale
Copy link

stale bot commented Jan 7, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 7, 2020
@jbibla jbibla removed the stale label Jan 7, 2020
@Bitcoinera
Copy link
Contributor Author

my idea would be to use a feature flag for it. if "block" is disabled, anywhere we show the block number should appear as plain text, not a link.

if enabled, they should be links.

but this is just one idea - there may be better ways to deal with this!

maybe the simplest thing to do is to show the "feature not available" screen for now.

I just realized we already have a feature flag for this 😅 It is called feature_explorer.

Yes, I know, quite confusing with the other one called feature_explore (which should be feature_portfolio), but this is working fine already. I just checked.

@Bitcoinera
Copy link
Contributor Author

OK, handled in #3411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants