-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling blocks of networks which haven't yet the feature activity implemented #3282
Comments
good catch. my idea would be to use a feature flag for it. if "block" is disabled, anywhere we show the block number should appear as plain text, not a link. if enabled, they should be links. but this is just one idea - there may be better ways to deal with this! maybe the simplest thing to do is to show the "feature not available" screen for now. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I just realized we already have a feature flag for this 😅 It is called Yes, I know, quite confusing with the other one called |
OK, handled in #3411 |
Describe the bug
You can see the blocks of networks which don't have yet the
activity
feature enabled. They look like empty, with no Chain ID.To Reproduce
Connect to Livepeer ( which hasn't
activity
yet implemented) and click on the block on the bottom (TmConnectedNetwork
). You will see this 'fake' empty block.Expected behavior
I think the ideal would be to have here the same modal of
Feature not yet available
.Screenshots
The fake empty block:
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: