Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstaking and clicking redelegation sets the to and from fields incorrectly #3096

Closed
jbibla opened this issue Nov 6, 2019 · 2 comments · Fixed by #3281
Closed

unstaking and clicking redelegation sets the to and from fields incorrectly #3096

jbibla opened this issue Nov 6, 2019 · 2 comments · Fixed by #3281
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@jbibla
Copy link
Collaborator

jbibla commented Nov 6, 2019

if i go to unstake from a validator, but i click the redelegate button - the "to" field becomes the validator i was intending to unstake from. this should be the opposite.

ideally, i'd propose we just use dropdowns for both "to" and "from" on the redelegation modal.

as well, maybe we should just put dropdowns for "to" and "from" for all staking modals.

@jbibla jbibla changed the title unstaking sets the to and from fields incorrectly unstaking and clicking redelegation sets the to and from fields incorrectly Nov 6, 2019
@Bitcoinera
Copy link
Contributor

Can you please add a screenshot of this? I only see redelegate as a highlighted word when I click "Undelegate". Like this:

image

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 18, 2019

yep! if you click the link you'll see the redelegation modal!

there a bunch of issues with this flow:

  • redelegation is kind of hidden (only shows a link to it from "undelegation")
  • maybe this separate modal is unnecessary - the "job to be done" is always going to be delegate or undelegate - redelegation is just a means to an end. we could integrate this concept into the "delegation" and "undelegation" modal

i think a good solution would be to:

  • make sure that the "from" field defaults to correct validator
  • make both "to" and "from" fields selectable dropdowns
  • remove the redelegation modal and just add the field to the undelegation modal instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants