Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update provider to SDK 0.47 #947

Closed
3 of 4 tasks
Tracked by #852
MSalopek opened this issue May 11, 2023 · 1 comment · Fixed by #918, #926 or #1019
Closed
3 of 4 tasks
Tracked by #852

Update provider to SDK 0.47 #947

MSalopek opened this issue May 11, 2023 · 1 comment · Fixed by #918, #926 or #1019
Assignees
@MSalopek
Labels
scope: cosmos-sdk Integration with Cosmos SDK type: refactoring Code refactoring type: tech-debt Slows down development in the long run

Comments

@MSalopek
Copy link
Contributor

MSalopek commented May 11, 2023 •
edited
Loading

The provider code needs to be migrated to cosmos-sdk v47 and ibc-go v47 and all breaking API changes need to be addressed.

Main concern is addressing library code, but app.go must also be upgraded (but new app wiring should not be used yet) because integration and MBT testing require it for creating mock chains.

e2e testing also depends on app.go but with different issues than integration and MBT tests. For e2e tests the actual binary has to be able to function correctly.

  • unit tests are operational
  • integration tests are operational
  • MBT/diff tests are operational
  • e2e tests are operational
@MSalopek MSalopek mentioned this issue May 11, 2023
Closed
9 tasks
@MSalopek MSalopek self-assigned this May 11, 2023
@MSalopek MSalopek added scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run type: refactoring Code refactoring labels May 11, 2023
@MSalopek MSalopek moved this to 👀 In review in Cosmos Hub May 11, 2023
@MSalopek MSalopek moved this from 👀 In review to 🏗 In progress in Cosmos Hub May 11, 2023
@MSalopek MSalopek moved this from 🏗 In progress to 👀 In review in Cosmos Hub May 11, 2023
This was linked to pull requests May 11, 2023
feat!: upgrade ics to ibc-go/v7 and cosmos-sdk/v0.47 #918
Merged
fix collect gentxs for provider app #926
Merged
@faddat
Copy link
Contributor

faddat commented May 15, 2023

It's done, just need your help with the end-to-end tests

@MSalopek MSalopek mentioned this issue May 17, 2023
Merged
18 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub May 22, 2023
@MSalopek MSalopek linked a pull request Jun 14, 2023 that will close this issue
feat!: upgrade ics sdk47 ibc7 #1019
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: cosmos-sdk Integration with Cosmos SDK type: refactoring Code refactoring type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
2 participants
@faddat @MSalopek