Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable consumer initiated slashing #689

Closed
2 tasks done
mpoke opened this issue Jan 30, 2023 · 0 comments · Fixed by #692
Closed
2 tasks done

Disable consumer initiated slashing #689

mpoke opened this issue Jan 30, 2023 · 0 comments · Fixed by #692
Assignees
@sainoe @shaspitz
Labels
type: feature-request New feature or request improvement
Milestone
ICS v1.0.0

Comments

@mpoke
Copy link
Contributor

mpoke commented Jan 30, 2023 •
edited by sainoe
Loading

Problem

A malicious consumer could send SlashPackets without validators actually misbehaving. This would be solve by having some type of provable evidence sent to the provider chain. This will be implemented as part of the https://github.com/cosmos/interchain-security/milestone/4 milestone.

In the meantime, the provider should only jail once (not slash) validators for downtime infractions. This requires the following changes:

  • provider drops SlashPackets that are not for downtime
  • provider doesn't call Slash or JailUntil
  • provider logs SlashPackets for double signing

Closing criteria

Consumer initiated slashing is disabled.

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@mpoke mpoke added type: feature-request New feature or request improvement product labels Jan 30, 2023
@mpoke mpoke added this to Cosmos Hub Jan 30, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 30, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Jan 30, 2023
@mpoke mpoke moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Jan 31, 2023
@mpoke mpoke assigned shaspitz and unassigned mpoke Jan 31, 2023
@mpoke mpoke added this to the ICS v1.0.0 milestone Feb 1, 2023
@sainoe sainoe mentioned this issue Feb 1, 2023
Merged
6 tasks
@MSalopek MSalopek mentioned this issue Feb 3, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Cosmos Hub Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

@shaspitz shaspitz

Labels
type: feature-request New feature or request improvement
Projects
Cosmos Hub
Status: ✅ Done
Milestone
ICS v1.0.0
Development

Successfully merging a pull request may close this issue.

disable consumer initiated slashing + fix slash acks bug cosmos/interchain-security
3 participants
@mpoke @sainoe @shaspitz