Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitTimeoutTimestamps and VscSendTimestamps not part of provider genesis state #612

Closed
2 tasks done
mpoke opened this issue Dec 19, 2022 · 2 comments · Fixed by #1076
Closed
2 tasks done

InitTimeoutTimestamps and VscSendTimestamps not part of provider genesis state #612

mpoke opened this issue Dec 19, 2022 · 2 comments · Fixed by #1076
Assignees
@yaruwangway
Labels
good first issue Good for newcomers type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run

Comments

@mpoke
Copy link
Contributor

mpoke commented Dec 19, 2022 •
edited
Loading

Problem

InitTimeoutTimestamps and VscSendTimestamps are not part of the provider's exported state.

Closing criteria

Export / import InitTimeoutTimestamps and VscSendTimestamps.

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@mpoke mpoke added type: bug Issues that need priority attention -- something isn't working ccv-core labels Dec 19, 2022
@mpoke mpoke moved this to Todo in Replicated Security Dec 19, 2022
@glnro glnro self-assigned this Dec 20, 2022
@glnro glnro moved this from Todo to In Progress in Replicated Security Dec 20, 2022
@cosmos cosmos deleted a comment Dec 20, 2022
@mpoke mpoke moved this from In Progress to Todo in Replicated Security Dec 22, 2022
@danwt danwt assigned danwt and unassigned glnro and danwt Jan 4, 2023
@mpoke mpoke added this to the ICS v1.1.0 milestone Jan 27, 2023
@mpoke mpoke added this to Cosmos Hub Jan 27, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 27, 2023
@mpoke mpoke modified the milestones: ICS v1.1.0, Create ICS docs, ICS next release Mar 5, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 5, 2023
@mpoke mpoke added good first issue Good for newcomers type: tech-debt Slows down development in the long run and removed ccv-core labels Jun 20, 2023
@mpoke mpoke removed this from the ICS next release milestone Jun 20, 2023
@mpoke mpoke assigned mpoke and yaruwangway and unassigned mpoke Jun 20, 2023
@yaruwangway yaruwangway moved this from 📥 Todo to 🛑 Blocked in Cosmos Hub Jun 21, 2023
@yaruwangway
Copy link
Contributor

yaruwangway commented Jun 22, 2023 •
edited
Loading

InitTimeoutTimestamps and VscSendTimestamps were not defined in genesis proto. since they are already in store, can just direct add them into exported genesis, this is not state breaking ?

another question is about VscSendTimestamps, all the VscId will be dumped to genesis, will that be too much data ?

@mpoke
Copy link
Contributor Author

mpoke commented Jun 22, 2023

InitTimeoutTimestamps and VscSendTimestamps were not defined in genesis proto. since they are already in store, can just direct add them into exported genesis, this is not state breaking ?

Yeah, it shouldn't be.

another question is about VscSendTimestamps, all the VscId will be dumped to genesis, will that be too much data ?

It will be a lot of data, but export genesis is a very rare operation. Also dumping the entire state of the staking module is expensive (millions of delegations).

@mpoke mpoke moved this from 🛑 Blocked to 🏗 In progress in Cosmos Hub Jun 22, 2023
@yaruwangway yaruwangway mentioned this issue Jun 23, 2023
Merged
20 tasks
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaruwangway yaruwangway

Labels
good first issue Good for newcomers type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: export InitTimeoutTimestamps and VscSendTimestamps to genesis cosmos/interchain-security
4 participants
@glnro @mpoke @danwt @yaruwangway