-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error-prone storage of throttled packet data #609
Comments
in Ie. it's confusing to be handling something that is "consumer data" in the provider store. Something like "packet data from consumer" would be easier to understand for quick readers |
Related: we could refactor all our enums to start from iota + 1, this avoids us accidentally having an uninitiliased enum masquerade as the zeroth enum value |
Implicitly closed by deleting all this shiz in #1102 |
Problem
We currently store throttled slash and vsc matured packet data in the same chain-specific queue. These types are serialized by a byte enum. This is error prone.
Closing criteria
Improve how we serialize that data. See if there's any built-in protobuf metadata we can use to infer the type of value bytes that are being deserialized here
Problem details
This is related to #567, but that issue is focused on JSON ser/deser from IBC core, whereas this issue deals with how the packet data types are persisted in the provider store during the throttling process.
The text was updated successfully, but these errors were encountered: