Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-prone storage of throttled packet data #609

Closed
Tracked by #713
shaspitz opened this issue Dec 16, 2022 · 3 comments
Closed
Tracked by #713

Error-prone storage of throttled packet data #609

shaspitz opened this issue Dec 16, 2022 · 3 comments
Labels
S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: feature-request New feature or request improvement type: refactoring Code refactoring

Comments

@shaspitz
Copy link
Contributor

Problem

We currently store throttled slash and vsc matured packet data in the same chain-specific queue. These types are serialized by a byte enum. This is error prone.

Closing criteria

Improve how we serialize that data. See if there's any built-in protobuf metadata we can use to infer the type of value bytes that are being deserialized here

Problem details

This is related to #567, but that issue is focused on JSON ser/deser from IBC core, whereas this issue deals with how the packet data types are persisted in the provider store during the throttling process.

@shaspitz
Copy link
Contributor Author

shaspitz commented Dec 22, 2022

in ccv.proto there is a ConsumerPacketData type, introduced by #626. When this type starts getting used in throttling code, we should consider refactoring its name to not include "consumer"

Ie. it's confusing to be handling something that is "consumer data" in the provider store. Something like "packet data from consumer" would be easier to understand for quick readers

@danwt
Copy link
Contributor

danwt commented Jan 3, 2023

Related: we could refactor all our enums to start from iota + 1, this avoids us accidentally having an uninitiliased enum masquerade as the zeroth enum value

@mpoke mpoke added this to Cosmos Hub Jan 27, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 27, 2023
@mpoke mpoke added this to the ICS v1.1.0 milestone Jan 27, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 5, 2023
@mpoke mpoke modified the milestones: ICS v1.1.0, ICS next release Mar 5, 2023
@mpoke mpoke moved this from 📥 Todo to 🛑 Blocked in Cosmos Hub Jun 20, 2023
@mpoke mpoke added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 13, 2023
@mpoke mpoke moved this from 🛑 F3: OnHold to 📥 F2: Todo in Cosmos Hub Sep 14, 2023
@shaspitz
Copy link
Contributor Author

Implicitly closed by deleting all this shiz in #1102

@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 14, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: feature-request New feature or request improvement type: refactoring Code refactoring
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants