Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade IBC go to v3.4.0 #498

Closed
2 tasks done
shaspitz opened this issue Nov 18, 2022 · 4 comments
Closed
2 tasks done

Upgrade IBC go to v3.4.0 #498

shaspitz opened this issue Nov 18, 2022 · 4 comments
Assignees
@sainoe
Labels
type: feature-request New feature or request improvement

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Nov 18, 2022 •
edited
Loading

Problem

We're currently using a v3 beta version of IBC go in this repo. v3.4.0 is a more up to date version with changes to the testing package that will prevent e2e testing bugs. Note that the current version of ibc go we reference is causing #493

Closing criteria

Upgrade to v3.4 and implement any neccessary refactors therein.

Problem details

See #493

https://github.com/cosmos/ibc-go/releases/tag/v3.4.0

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@shaspitz shaspitz added the type: feature-request New feature or request improvement label Nov 18, 2022
@shaspitz shaspitz moved this to Todo in Replicated Security Nov 18, 2022
@shaspitz shaspitz mentioned this issue Nov 19, 2022
Closed
2 tasks
@shaspitz shaspitz changed the title Upgrade IBC go to v3.4 Upgrade IBC go to v3.4.0 Nov 19, 2022
@danwt
Copy link
Contributor

danwt commented Nov 19, 2022

Interesting! I'd definitely be happy to upgrade. I'm curious, what are the bugs that are fixed in 3.4?

Btw, just for reference, we have several of our own commits on our fork head, some of which might want to be rebased

https://github.com/informalsystems/ibc-go/commits/interchain-security-2

@danwt
Copy link
Contributor

danwt commented Dec 1, 2022

cc @sainoe @glnro

@danwt danwt removed their assignment Dec 1, 2022
@shaspitz
Copy link
Contributor Author

shaspitz commented Dec 1, 2022

Note, to fix the problems I was facing when this issue was made, I just added commits to our IBC 3.0 fork. I didn't get very far on upgrading to 3.4. Happy to help as needed tho!

@jtremback jtremback moved this from Todo to Waiting for review in Replicated Security Dec 5, 2022
@sainoe
Copy link
Contributor

sainoe commented Dec 8, 2022

Solved in #559

@sainoe sainoe closed this as completed Dec 8, 2022
Repository owner moved this from Waiting for review to Done in Replicated Security Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
type: feature-request New feature or request improvement
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sainoe @danwt @shaspitz