Check if any of the cryptographicIdentity util methods are equivalent

[danwt]

Problem

When writing any code involving keys or addresses it is hard to know the exact meanings of each type required in a method signature. The cryptographic utilities implement helpers to get those types. Some of those types may refer to the same thing.

Closing criteria

Check if any of the return values from the crypto identity methods are equivalent, and if they are, document them as such

https://github.com/cosmos/interchain-security/blob/main/testutil/crypto/crypto.go

TODOs

• Labels have been added for issue
• Issue has been added to the ICS project

[shaspitz]

My hunch is that some of the utils do return equivalents. At least, I was able to use multiple different methods without tests failing when making a first pass at #473. The new util file is still a huuuuge improvement from before 🙏

[shaspitz]

Note that #473 was closed because it got too behind. A future PR could use that PR as inspiration but use the utils correctly, maybe fix this issue in the same PR

[danwt]

Note, this issue is related to #572

[mpoke]

@danwt does #672 address this issue?

[danwt]

Will be superseded by pending solution to #572