Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated tags for HandleConsumerAdditionProposal and HandleConsumerRemovalProposal #390

Closed
mpoke opened this issue Oct 12, 2022 · 1 comment · Fixed by #539
Closed

Outdated tags for HandleConsumerAdditionProposal and HandleConsumerRemovalProposal #390

mpoke opened this issue Oct 12, 2022 · 1 comment · Fixed by #539
Assignees
@mpoke
Labels
type: refactoring Code refactoring

Comments

@mpoke
Copy link
Contributor

mpoke commented Oct 12, 2022

Problem

This PR on the spec side will make the comments (i.e., the tags) for both HandleConsumerAdditionProposal and HandleConsumerRemovalProposal outdated. See here and here.

Closing criteria

Update comments.
@mpoke mpoke added the type: refactoring Code refactoring label Oct 12, 2022
@mpoke mpoke moved this to Todo in Replicated Security Oct 12, 2022
@MSalopek MSalopek mentioned this issue Nov 9, 2022
Closed
@jtremback
Copy link
Contributor

@mpoke did this get corrected?

@mpoke mpoke self-assigned this Dec 1, 2022
@mpoke mpoke mentioned this issue Dec 1, 2022
Merged
2 tasks
@mpoke mpoke moved this from Todo to Waiting for review in Replicated Security Dec 1, 2022
Repository owner moved this from Waiting for review to Done in Replicated Security Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpoke mpoke

Labels
type: refactoring Code refactoring
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
2 participants
@jtremback @mpoke