Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test full unbonding functionality in integration tests #311

Closed
shaspitz opened this issue Aug 30, 2022 · 4 comments
Closed

Test full unbonding functionality in integration tests #311

shaspitz opened this issue Aug 30, 2022 · 4 comments
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

#94 added a simple check that validator powers are changed when an unbond tx is submitted. We still need to test token liquidity after unbonding period has elapsed, and any anything else that's related to full unbonding hooks

This will require genesis file manipulation, see genesisChanges in integration-tests/config.go as example
@shaspitz shaspitz added the scope: testing Code review, testing, making sure the code is following the specification. label Aug 30, 2022
@mpoke mpoke moved this to Todo in Replicated Security Oct 11, 2022
@danwt
Copy link
Contributor

danwt commented Nov 30, 2022

Echoing the comment here

I think testing this with integration tests is not a valuable use of time. It's already fairly thoroughly covered by diff tests and @MSalopek is improving that even more.

@danwt
Copy link
Contributor

danwt commented Nov 30, 2022

I'm going to close for now, please reopen and justify as you see fit.

@danwt danwt closed this as completed Nov 30, 2022
Repository owner moved this from Todo to Done in Replicated Security Nov 30, 2022
@shaspitz
Copy link
Contributor Author

As mentioned in the other issue, integration tests for unbonding functionality would be a sanity check that the real system works. I'm fine closing this issue so long as full unbonding is being validated in the testnet. @jtremback or @mpoke could you confirm this is the case?

@jtremback jtremback reopened this Nov 30, 2022
Repository owner moved this from Done to In Progress in Replicated Security Nov 30, 2022
@jtremback
Copy link
Contributor

re-closing in favor of #361

Repository owner moved this from In Progress to Done in Replicated Security Nov 30, 2022
@jtremback jtremback mentioned this issue Nov 30, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jtremback @danwt @shaspitz