Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protobuf to define CCV state #213

Closed
mpoke opened this issue Jul 7, 2022 · 2 comments · Fixed by #332
Closed

Use protobuf to define CCV state #213

mpoke opened this issue Jul 7, 2022 · 2 comments · Fixed by #332
Assignees
@MSalopek
Labels
good first issue Good for newcomers

Comments

@mpoke
Copy link
Contributor

mpoke commented Jul 7, 2022

ref. #188 (comment)
@mpoke mpoke added good first issue Good for newcomers ccv-core labels Jul 7, 2022
@MSalopek
Copy link
Contributor

MSalopek commented Sep 5, 2022

For more context, there seem are places where json.Marshal() is called directly because the relevant types were not created using protobuffs

There's some more in the same file. All examples of using json.Marshal seem to be related to managing unbonding operations.

@jtremback
Copy link
Contributor

This is done, but not merged yet. Closing

@MSalopek MSalopek linked a pull request Sep 8, 2022 that will close this issue
use protobufs to define ccv state #332
Merged
@mpoke mpoke reopened this Sep 8, 2022
@mpoke mpoke mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
good first issue Good for newcomers
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use protobufs to define ccv state MSalopek/interchain-security
3 participants
@jtremback @mpoke @MSalopek