-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK changes to 0.45.6 #204
Comments
First wait for |
I would rather identify the staking changes first and if they are breaking. If they are this will not be time well spent, if they are not then coordination with the hub team as to what version will be on the hub at time of launch is needed and then updating to that version. Is there a list of changes that were made to the staking module |
Not really. Once cosmos/cosmos-sdk#12796 is merged, I want to open a PR against v0.45.1 that will contain all the changes. Mainly, the changes to staking are
Probably v0.46. However, the consumer chain also requires some of these changes (the ones targeting evidence and slashing, @sainoe can share more details here) and consumer chains may use SDK v0.45. The reason I want to rebase https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase on v0.45.6, is that v0.45.6 contains some fixes that solves some issues with the git checks. Not that important though. |
@marbar3778 @mpoke I thought that when we talked last week, we decided that it was OK for the Cosmos SDK team to review in its current form, and then we will update to 46 (or 47?) later. Is this the case? If so, @mpoke can you close this issue? |
The branch https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase with SDK changes needed by IS should be rabased on SDK v0.45.6
The text was updated successfully, but these errors were encountered: