Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create lightweight version for GetAllConsumerChains #1943

Closed
mpoke opened this issue Jun 6, 2024 · 0 comments · Fixed by #1946
Closed

Create lightweight version for GetAllConsumerChains #1943

mpoke opened this issue Jun 6, 2024 · 0 comments · Fixed by #1946
Assignees
@mpoke
Labels
scope: provider Issues related to the provider chain source: production To indicate an issue found in production. type: bug Issues that need priority attention -- something isn't working type: refactoring Code refactoring

Comments

@mpoke
Copy link
Contributor

mpoke commented Jun 6, 2024 •
edited
Loading

Problem

GetAllConsumerChains returns a list of Chain data types, but it's used in many places where only a list of chainIDs would be sufficient.

Closing criteria

A method GetAllConsumerChainIDs is added that returns a list of chainIDs (and clientIDs). This method is used instead of GetAllConsumerChains in the following places:

  • GetAllRegisteredAndProposedChainIDs
  • SendVSCPackets
  • QueueVSCPackets and use GetTopN to get the topN info
  • AfterUnbondingInitiated
  • QueryConsumerChainsValidatorHasToValidate
  • ExportGenesis
  • AllocateTokens
@mpoke mpoke added type: bug Issues that need priority attention -- something isn't working type: refactoring Code refactoring scope: provider Issues related to the provider chain source: production To indicate an issue found in production. labels Jun 6, 2024
@mpoke mpoke assigned insumity and mpoke and unassigned insumity Jun 6, 2024
@mpoke mpoke mentioned this issue Jun 7, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpoke mpoke

Labels
scope: provider Issues related to the provider chain source: production To indicate an issue found in production. type: bug Issues that need priority attention -- something isn't working type: refactoring Code refactoring
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Replace GetAllConsumerChains with lightweight version cosmos/interchain-security
2 participants
@insumity @mpoke