Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop nil voters when handling misbehaviour #1403

Closed
Tracked by #732
sainoe opened this issue Nov 10, 2023 · 0 comments
Closed
Tracked by #732

Drop nil voters when handling misbehaviour #1403

sainoe opened this issue Nov 10, 2023 · 0 comments
Assignees

Comments

@sainoe
Copy link
Contributor

sainoe commented Nov 10, 2023

Problem

Validators who vote nil don't have their signature verified in comet. Consequently, they should not be extracted as byzantine validators when handling MsgConsumerMisbehaviour, find the complete bug report here.

Edit: It's also critical that we check that Misbehaviours comes from a valid consumer chain light client. Otherwise the above isn't sufficient to stop an attacker from introducing bogus validator signatures.

Props to @insumity for finding this issue ❤️.

@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Nov 10, 2023
@sainoe sainoe self-assigned this Nov 10, 2023
@sainoe sainoe moved this from 🩹 F1: Triage to 👀 F3: InReview in Cosmos Hub Nov 10, 2023
@sainoe sainoe closed this as completed Nov 13, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Nov 13, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant