Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out consumer genesis state #1214

Closed
shaspitz opened this issue Aug 18, 2023 · 3 comments · Fixed by #1324
Closed

Split out consumer genesis state #1214

shaspitz opened this issue Aug 18, 2023 · 3 comments · Fixed by #1324
Assignees
@bermuell
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Aug 18, 2023 •
edited
Loading

Problem

#1071 has illuminated that the provider module references the consumer genesis type. See shared_consumer.proto. Note also that a lot of the fields in the consumer's genesis state struct are zeroed out when that genesis state is queried from provider.

We should create a new struct which holds the info that a consumer actually needs from the provider (ie. no extraneous zeroed fields), this type will trivially be shared between consumer and provider. Then the consumer genesis state (only referenced by consumer) can have a field for the shared type. This allows us to make types like HeightToValsetUpdateID, OutstandingDowntime only relevant to the consumer.

Closing criteria

Make changes as described

Problem details
@shaspitz shaspitz added status: waiting-triage This issue/PR has not yet been triaged by the team. good first issue Good for newcomers labels Aug 18, 2023
@maharsh312
Copy link

i'll like to work on this, can you assign it to me?

@mpoke mpoke removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Aug 21, 2023
@mpoke mpoke added this to Cosmos Hub Aug 21, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 21, 2023
@mpoke mpoke moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Aug 21, 2023
@mpoke
Copy link
Contributor

mpoke commented Aug 21, 2023

@maharsh312 I assigned it to you. Thanks for working on this. Please let us know if you need help.

@shaspitz shaspitz mentioned this issue Aug 21, 2023
Merged
20 tasks
@mpoke
Copy link
Contributor

mpoke commented Aug 30, 2023

@maharsh312 Could you please confirm that you're working on this issue? Do you have an ETA?

@bermuell bermuell self-assigned this Sep 11, 2023
@mpoke mpoke moved this from 🏗 F3: InProgress to 📥 F2: Todo in Cosmos Hub Sep 12, 2023
@mpoke mpoke added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 14, 2023
@bermuell bermuell moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Sep 15, 2023
@bermuell bermuell mentioned this issue Sep 22, 2023
Merged
21 tasks
@bermuell bermuell moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Oct 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Oct 13, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bermuell bermuell

Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Split out consumer genesis state cosmos/interchain-security
4 participants
@maharsh312 @mpoke @bermuell @shaspitz