Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cosmos-sdk with LSM changes in ICS v2 #1183

Closed
6 of 7 tasks
MSalopek opened this issue Aug 3, 2023 · 0 comments · Fixed by #1120
Closed
6 of 7 tasks

support cosmos-sdk with LSM changes in ICS v2 #1183

MSalopek opened this issue Aug 3, 2023 · 0 comments · Fixed by #1120
Assignees
Labels
admin: epic An EPIC -- meta issue used to track a body of work type: feature-request New feature or request improvement

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Aug 3, 2023

Summary

This thread on the forum and the resulting governance proposal requires that the LSM be included on Gaia.

cosmos/cosmos-sdk#16747 adds LSM to cosmos-sdk v45-ics

Problem Definition

Since Gaia is an ICS provider the ICS functionality must be maintained and no liveness or safety concerns regarding ICS integrating with LSM should be left unadressed.

To achieve this goal some features from ICS v3 (using cosmos-sdk v47) must be backported to ICS v2.
Since the changes are state breaking this would most likely yield in releasing ICS v2.1 that supports the LSM feature.

Proposal

Backport fixes, features and testing from ICS v3 into v2 to support LSM:

  1. backport CancelUnbonding special handling. Context listed below:
  2. backport tests
    • add support to the "old" e2e test suite
    • backport integration tests

Task list

Must have

Preview Give feedback

Nice to have

Preview Give feedback

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@MSalopek MSalopek added type: feature-request New feature or request improvement admin: epic An EPIC -- meta issue used to track a body of work status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 3, 2023
@MSalopek MSalopek self-assigned this Aug 3, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 3, 2023
@MSalopek MSalopek moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Aug 3, 2023
@MSalopek MSalopek linked a pull request Aug 3, 2023 that will close this issue
8 tasks
@MSalopek MSalopek moved this from 🏗 In progress to 👀 In review in Cosmos Hub Aug 7, 2023
@mpoke mpoke moved this from 👀 In review to 🛑 Blocked in Cosmos Hub Aug 8, 2023
@mpoke mpoke removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Aug 16, 2023
@mpoke mpoke moved this from 🛑 Blocked to 🏗 In progress in Cosmos Hub Aug 16, 2023
@mpoke mpoke assigned mpoke and unassigned MSalopek Aug 16, 2023
@mpoke mpoke closed this as completed Aug 16, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Cosmos Hub Aug 16, 2023
@mpoke mpoke assigned MSalopek and unassigned mpoke Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin: epic An EPIC -- meta issue used to track a body of work type: feature-request New feature or request improvement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants