Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address race conditions in ICS misbehaviour handling #1147

Closed
Tracked by #732
sainoe opened this issue Jul 14, 2023 · 0 comments · Fixed by #1148
Closed
Tracked by #732

Address race conditions in ICS misbehaviour handling #1147

sainoe opened this issue Jul 14, 2023 · 0 comments · Fixed by #1148
Assignees

Comments

@sainoe
Copy link
Contributor

sainoe commented Jul 14, 2023

Problem

In the event of a IBC light client attack on the consumer, the associated client hosted on the provider can get frozen due to either the reception of an ICS misbehaviour message or a canonical IBC misbehaviour message. However, this creates a race condition that could cause the ICS misbehavior handling to fail. As a result, the byzantine validators responsible for the light client attack may not be adequately jailed as intended.

Closing criteria

Remove the ICS misbehavior handling logic updating the IBC client status

@sainoe sainoe changed the title Address the race condition in ICS misbehaviour Address the race condition in ICS misbehaviour handling Jul 14, 2023
@sainoe sainoe moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Jul 14, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jul 14, 2023
@sainoe sainoe changed the title Address the race condition in ICS misbehaviour handling Address the race condition in the ICS misbehaviour handling Jul 14, 2023
@sainoe sainoe changed the title Address the race condition in the ICS misbehaviour handling Address race conditions in the ICS misbehaviour handling Jul 14, 2023
@sainoe sainoe changed the title Address race conditions in the ICS misbehaviour handling Address race conditions in ICS misbehaviour handling Jul 14, 2023
@sainoe sainoe self-assigned this Jul 17, 2023
@sainoe sainoe moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jul 17, 2023
@sainoe sainoe moved this from 👀 In review to 🛑 Blocked in Cosmos Hub Jul 17, 2023
@mpoke mpoke linked a pull request Jul 24, 2023 that will close this issue
20 tasks
@sainoe sainoe moved this from 🛑 Blocked to 🏗 In progress in Cosmos Hub Jul 24, 2023
@sainoe sainoe moved this from 🏗 In progress to 👀 In review in Cosmos Hub Aug 4, 2023
@mpoke mpoke closed this as completed Aug 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants