Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ICS misbehaviour msg definition #1125

Closed
Tracked by #732
sainoe opened this issue Jul 10, 2023 · 4 comments
Closed
Tracked by #732

Update ICS misbehaviour msg definition #1125

sainoe opened this issue Jul 10, 2023 · 4 comments
Assignees
@sainoe
Labels
S: NewThings Work towards your business objectives with new products, features, or integrations

Comments

@sainoe
Copy link
Contributor

sainoe commented Jul 10, 2023 •
edited
Loading

Problem

The current ICS misbehaviour msg contains a concrete IBC Tendermint Client Misbehaviour types. Consequently, the ICS misbehaviour handler isn't compatible with all the IBC client implementations.

Closing criteria

Update the ICS misbehaviour msg and handler to work with the IBC misbehavior interface definition.
@sainoe sainoe mentioned this issue Jul 10, 2023
Closed
@sainoe sainoe self-assigned this Jul 11, 2023
@sainoe sainoe mentioned this issue Jul 11, 2023
Closed
20 tasks
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jul 11, 2023
@sainoe sainoe moved this from 🩹 Triage to 🛑 Blocked in Cosmos Hub Jul 11, 2023
@sainoe sainoe moved this from 🛑 Blocked to 👀 In review in Cosmos Hub Jul 17, 2023
@sainoe sainoe moved this from 👀 In review to 🛑 Blocked in Cosmos Hub Jul 17, 2023
@mpoke
Copy link
Contributor

mpoke commented Jul 18, 2023

@sainoe Is this actually a problem? Currently ICS is implemented assuming the consumer chains use Tendermint / CometBFT as a consensus engine.

@sainoe
Copy link
Contributor Author

sainoe commented Jul 18, 2023

@mpoke agree it isn't a problem, rather a cheap enhancement

@ancazamfir
Copy link
Contributor

@mpoke agree it isn't a problem, rather a cheap enhancement

I agree with @mpoke comment and not sure about the benefit of generalizing ICS only for the misbehaviour aspect.

@mpoke mpoke linked a pull request Jul 24, 2023 that will close this issue
feat: update ICS misbehaviour to work with all IBC client implementations #1128
Closed
20 tasks
@sainoe sainoe moved this from 🛑 Blocked to 👀 In review in Cosmos Hub Jul 24, 2023
@mpoke mpoke added the S: NewThings Work towards your business objectives with new products, features, or integrations label Sep 14, 2023
@mpoke mpoke moved this from 👀 F3: InReview to 🛑 F3: OnHold in Cosmos Hub Sep 14, 2023
@sainoe sainoe moved this from 🛑 F3: OnHold to 🤔 F1: Investigate in Cosmos Hub Sep 22, 2023
@sainoe
Copy link
Contributor Author

sainoe commented Nov 21, 2023

The issue was decided to be not needed.

@sainoe sainoe closed this as completed Nov 21, 2023
@github-project-automation github-project-automation bot moved this from 🤔 F1: Investigate to 👍 F4: Assessment in Cosmos Hub Nov 21, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
S: NewThings Work towards your business objectives with new products, features, or integrations
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update ICS misbehaviour to work with all IBC client implementations cosmos/interchain-security
3 participants
@ancazamfir @mpoke @sainoe