Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reintroduce and refactor make proto-check #1041

Closed
MSalopek opened this issue Jun 20, 2023 · 0 comments · Fixed by #1060
Closed

reintroduce and refactor make proto-check #1041

MSalopek opened this issue Jun 20, 2023 · 0 comments · Fixed by #1060
Assignees
@MSalopek
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working type: refactoring Code refactoring type: tech-debt Slows down development in the long run

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Jun 20, 2023 •
edited
Loading

Problem

make proto-check command has been disabled in feat/upgrade-ics-sdk47-ibc7 because the command would fail to run successfully in CI, even though it was passing without issues locally.

Since the command was run as part of automated-tests.yml its failure meant that all tests would fail.

Closing criteria

Reintroduce the make proto-check and fix any existing incompatibilities with new tooling.

Problem details
@MSalopek MSalopek added type: bug Issues that need priority attention -- something isn't working scope: testing Code review, testing, making sure the code is following the specification. type: tech-debt Slows down development in the long run type: refactoring Code refactoring labels Jun 20, 2023
@MSalopek MSalopek self-assigned this Jun 20, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jun 20, 2023
@MSalopek MSalopek moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Jun 20, 2023
@MSalopek MSalopek mentioned this issue Jun 20, 2023
Merged
20 tasks
@shaspitz shaspitz mentioned this issue Jun 21, 2023
Closed
8 tasks
@MSalopek MSalopek mentioned this issue Jun 21, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working type: refactoring Code refactoring type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
1 participant
@MSalopek