Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add serde feature to derive Serialize and Deserialize on all Protobuf definitions #145

Closed
wants to merge 2 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Apr 19, 2023

Closes: #144

@romac romac added the rust Issues pertaining to the Rust implementation label Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +40.62 🎉

Comparison is base (d28ea7a) 50.54% compared to head (6a7c653) 91.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #145       +/-   ##
===========================================
+ Coverage   50.54%   91.17%   +40.62%     
===========================================
  Files          23        7       -16     
  Lines        8034     1700     -6334     
  Branches       86        0       -86     
===========================================
- Hits         4061     1550     -2511     
+ Misses       3616      150     -3466     
+ Partials      357        0      -357     
Flag Coverage Δ
go ?
rust 91.17% <0.00%> (-0.98%) ⬇️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/src/cosmos.ics23.v1.rs 13.41% <0.00%> (-3.78%) ⬇️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romac
Copy link
Member Author

romac commented Apr 19, 2023

CI failure is due to Codecov, I think we can just ignore it.

@romac
Copy link
Member Author

romac commented Apr 19, 2023

This should only require a patch version bump to 0.10.1 since adding trait impls for serde cannot cause compilation failures in downstream code afaik.

Alternatively, we could omit the derived serialization impls on the ibc.core.commitment protos in ibc-proto but that might break downstream code for those who rely on it.

Let me know what you think

@romac
Copy link
Member Author

romac commented Apr 22, 2023

Superseded by #146 which brings ProtoJSON-compatible Serialize and Deserialize instances, as per @hdevalence's suggestion.

@romac romac closed this Apr 22, 2023
@romac romac deleted the romac/serde branch April 22, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Issues pertaining to the Rust implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust: Add serde feature to derive Serialize and Deserialize on all Protobuf definitions
1 participant