ICS03/ICS26: Some inconsistencies

[michwqy]

If I understand this correctly, ConnOpenInit called by handleConnOpenInit in ICS26 should correspond to connOpenInit in ICS03.
In ICS03, connOpenInit takes counterpartyPrefix, clientIdentifier, counterpartyClientIdentifier, version as parameters.

function connOpenInit(
  counterpartyPrefix: CommitmentPrefix,
  clientIdentifier: Identifier,
  counterpartyClientIdentifier: Identifier,
  version: string,
  delayPeriodTime: uint64,
  delayPeriodBlocks: uint64) {
......
}

But in ICS26, connOpenInit takes identifier, desiredCounterpartyIdentifier, clientIdentifier, counterpartyClientIdentifier, version as parameters.

function handleConnOpenInit(datagram: ConnOpenInit) {
    handler.connOpenInit(
      datagram.identifier,
      datagram.desiredCounterpartyIdentifier,
      datagram.clientIdentifier,
      datagram.counterpartyClientIdentifier,
      datagram.version
    )
}

I don't quite understand how counterpartyPrefix and identifier, desiredCounterpartyIdentifier correspond to each other. In my understanding, there's no way to know connectionIdentifier and counterpartyconnectionIdentifier when connOpenInit is called.

[crodriguezvega]

Hi @michwqy. Thanks for opening this issue. I think there's a mistake in ICS 26, so I have opened this PR to fix it.

[michwqy]

Thanks @crodriguezvega.