Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS28: Reflect that unbonding maturations occur after Staking.EndBlock in spec #825

Closed
danwt opened this issue Aug 25, 2022 · 2 comments · Fixed by #826
Closed

ICS28: Reflect that unbonding maturations occur after Staking.EndBlock in spec #825

danwt opened this issue Aug 25, 2022 · 2 comments · Fixed by #826
Assignees
@mpoke
Labels
app Application layer. implementation Tracking an external implementation of the spec.

Comments

@danwt
Copy link
Contributor

danwt commented Aug 25, 2022

Mirror issue

Long story short, in the code unbonding maturations complete after Staking.EndBlock but in the spec they happen before.
@danwt danwt assigned mpoke and danwt and unassigned danwt Aug 25, 2022
@mpoke mpoke added app Application layer. implementation Tracking an external implementation of the spec. labels Aug 26, 2022
@mpoke mpoke moved this to Todo in Replicated Security Aug 26, 2022
@mpoke mpoke moved this from Todo to Next in Replicated Security Aug 26, 2022
@mpoke
Copy link
Contributor

mpoke commented Aug 29, 2022

@danwt I think this issue is a duplicate of #781, right?

@mpoke mpoke moved this from Next to Waiting for review in Replicated Security Aug 29, 2022
@danwt danwt mentioned this issue Aug 30, 2022
Closed
@danwt
Copy link
Contributor Author

danwt commented Aug 30, 2022

It's more or less a duplicate yes, I've closed the other one now. I had written something a bit misleading there anyway.

@mpoke mpoke mentioned this issue Aug 30, 2022
Merged
@mpoke mpoke closed this as completed in #826 Dec 1, 2022
Repository owner moved this from Waiting for review to Done in Replicated Security Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpoke mpoke

Labels
app Application layer. implementation Tracking an external implementation of the spec.
Projects
IBC-GO Eureka
Status: Backlog
Replicated Security
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ICS28: Reflect deferred unbonding completion in spec cosmos/ibc
2 participants
@mpoke @danwt