Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS28: Set initH in onChanOpenConfirm #702

Closed
mpoke opened this issue Mar 30, 2022 · 0 comments
Closed

ICS28: Set initH in onChanOpenConfirm #702

mpoke opened this issue Mar 30, 2022 · 0 comments
Assignees
Labels
app Application layer. wip Issues or pull requests which are in progress.

Comments

@mpoke
Copy link
Contributor

mpoke commented Mar 30, 2022

Currently, the initH mapping (i.e., it stores for every consumer chain the height when the first VSC was provided to that consumer chain) is set in the EndBlock after checking whether it was previously set. Since this is inefficient (i.e., lots of lookups), it is better to set it in onChanOpenConfirm once the CCV channel is established. Note that even if initH would contain a height h1 preceding the height h2 when the first VSC was provided, the validator set and the delegations between h1 and h2 will remain unchanged; otherwise, a VSC would have been provided.

@mpoke mpoke self-assigned this Mar 30, 2022
@mpoke mpoke added the app Application layer. label Mar 30, 2022
@mpoke mpoke added the wip Issues or pull requests which are in progress. label Apr 11, 2022
@mpoke mpoke closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application layer. wip Issues or pull requests which are in progress.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant