Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure capability key usage #301

Closed
cwgoes opened this issue Nov 4, 2019 · 4 comments · Fixed by #400
Closed

Restructure capability key usage #301

cwgoes opened this issue Nov 4, 2019 · 4 comments · Fixed by #400
Assignees
@cwgoes
Labels
from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Milestone
IBC Specification...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 4, 2019 •
edited
Loading

It's just way too confusing for implementers, especially the way the store is used.

Not yet sure how best to do this, might be wise to consult with Agoric.

@fedekunze feedback would be helpful on spec changes here.
@cwgoes cwgoes added tao Transport, authentication, & ordering layer. from-review Feedback / alterations from specification review. labels Nov 4, 2019
@cwgoes cwgoes added this to the IBC Specification 1.0.0 milestone Nov 4, 2019
@cwgoes cwgoes self-assigned this Nov 4, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 5, 2019

Action item: @cwgoes to ask Agoric what they think / for an example.

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 25, 2019 •
edited
Loading

Maybe we should include the capability store interface (ref cosmos/cosmos-sdk#5290) in the spec, as opposed to the imprecise privateStore usage currently in place for capability keys.

@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 12, 2019 •
edited
Loading

Ref cosmos/cosmos-sdk#5397

If that rough interface is accepted we can update the IBC specs to use it.

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 22, 2020

I think it's prudent to block this on cosmos/cosmos-sdk#5542 and come to consensus on the API.

@cwgoes cwgoes mentioned this issue Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
IBC Specification 1.0.0
Development

Successfully merging a pull request may close this issue.

Rework capability API throughout specification cosmos/ibc
1 participant
@cwgoes