Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional acknowledgements of success / failure for packets #135

Closed
cwgoes opened this issue Jun 25, 2019 · 3 comments · Fixed by #144
Closed

Optional acknowledgements of success / failure for packets #135

cwgoes opened this issue Jun 25, 2019 · 3 comments · Fixed by #144
Assignees
Labels
tao Transport, authentication, & ordering layer.
Milestone

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 25, 2019

Split off from #126.

  • Acknowledgements can be enabled as an option on a channel.
  • Acknowledgements that would be no-ops need not be actually executed.
@cwgoes cwgoes added the tao Transport, authentication, & ordering layer. label Jun 25, 2019
@cwgoes cwgoes self-assigned this Jun 25, 2019
@cwgoes cwgoes added this to the Specification Clarification milestone Jun 25, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 2, 2019

Simple model:

  • On packet execution, application can return opaque bytestring which the IBC handler will store a commitment to

Questions:

  • Should application-level failures close ordered channels or should applications close manually?
  • Does the IBC protocol itself need to understand the acknowledgement data (status bit for success / failure) or can it be opaque?

@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 2, 2019

Instead of having acknowledgements be an option on the channel I think the receiving module can just choose to write empty data.

@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 2, 2019

For now - modules will just close channels as normal. We need to think more about the closing handshake and what happens when modules misbehave in the middle of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tao Transport, authentication, & ordering layer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant