Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Router from {Validation,Execution}Context #788

Closed
plafer opened this issue Jul 27, 2023 · 0 comments · Fixed by #789
Closed

Decouple Router from {Validation,Execution}Context #788

plafer opened this issue Jul 27, 2023 · 0 comments · Fixed by #789
Assignees
@plafer
Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components
Milestone
v0.44.0

Comments

@plafer
Copy link
Contributor

plafer commented Jul 27, 2023

Having both the Router and ExecutionContext be forced to be implemented on the same struct makes us run into issues where we need a &mut for the Router, and &mut for the ExecutionContext, which Rust doesn't allow. Separating them solves this problem.

Related: #786
@plafer plafer self-assigned this Jul 27, 2023
@plafer plafer added this to ibc-rs Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jul 27, 2023
@plafer plafer mentioned this issue Jul 27, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added the O: decoupling Objective: aims to separate concerns and cause to independent, reusable components label Aug 1, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 1, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.44.0 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.44.0
Development

Successfully merging a pull request may close this issue.

Decouple Router from ValidationContext cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani