Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up generic String variants in error types #1347

Merged
merged 21 commits into from
Sep 20, 2024

Merge branch 'imp/clean-up-string-variants' of https://github.com/cos…

bd6e694
Select commit
Loading
Failed to load commit list.
Merged

Clean up generic String variants in error types #1347

Merge branch 'imp/clean-up-string-variants' of https://github.com/cos…
bd6e694
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 62.26054% with 197 lines in your changes missing coverage. Please review.

Please upload report for BASE (error-handling@4aecaec). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ibc-core/ics02-client/types/src/events.rs 56.41% 34 Missing ⚠️
...ore/ics24-host/cosmos/src/upgrade_proposal/plan.rs 0.00% 10 Missing ⚠️
...ics24-host/cosmos/src/upgrade_proposal/proposal.rs 0.00% 8 Missing ⚠️
...core/ics24-host/cosmos/src/validate_self_client.rs 0.00% 8 Missing ⚠️
ibc-testkit/src/testapp/ibc/clients/mod.rs 0.00% 8 Missing ⚠️
ibc-core/ics02-client/types/src/error.rs 0.00% 7 Missing ⚠️
.../ics03-connection/types/src/msgs/conn_open_init.rs 41.66% 7 Missing ⚠️
...ore/ics04-channel/types/src/msgs/chan_open_init.rs 50.00% 7 Missing ⚠️
ibc-core/ics03-connection/types/src/connection.rs 33.33% 6 Missing ⚠️
ibc-query/src/core/client/types/request.rs 0.00% 6 Missing ⚠️
... and 45 more
Additional details and impacted files 
@@                Coverage Diff                @@
##             error-handling    #1347   +/-   ##
=================================================
  Coverage                  ?   66.80%           
=================================================
  Files                     ?      225           
  Lines                     ?    22675           
  Branches                  ?        0           
=================================================
  Hits                      ?    15148           
  Misses                    ?     7527           
  Partials                  ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov